Nag to close leave-open bugs only when no deps or deps are all closed #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-c
reviewed
Feb 8, 2021
Comment on lines
+55
to
+58
| bugids = set() | ||
| for info in bugs.values(): | ||
| bugids.update(info["depends_on"]) | ||
| bugids = list(bugids) |
There was a problem hiding this comment.
Nit:
Suggested change
| bugids = set() | |
| for info in bugs.values(): | |
| bugids.update(info["depends_on"]) | |
| bugids = list(bugids) | |
| bugids = list(set(sum((info["depends_on"] for info in bugs.values()), []))) |
marco-c
reviewed
Feb 8, 2021
Comment on lines
+55
to
+58
| bugids = set() | ||
| for info in bugs.values(): | ||
| bugids.update(info["depends_on"]) | ||
| bugids = list(bugids) |
There was a problem hiding this comment.
Can you rename the variable dependencies_ids, so it's clearer what it refers to?
marco-c
reviewed
Feb 8, 2021
Comment on lines
+68
to
+74
| to_fix = {} | ||
| for bugid, info in bugs.items(): | ||
| deps = set(info["depends_on"]) | ||
| if not (deps & open_bugs): | ||
| to_fix[bugid] = info | ||
|
|
||
| return to_fix |
There was a problem hiding this comment.
Nit:
Suggested change
| to_fix = {} | |
| for bugid, info in bugs.items(): | |
| deps = set(info["depends_on"]) | |
| if not (deps & open_bugs): | |
| to_fix[bugid] = info | |
| return to_fix | |
| return {bug_id: info for bug_id, info in bugs.items() if not (set(info["depends_on"]) & open_bugs)} |
marco-c
reviewed
Feb 8, 2021
|
|
||
| def filter_deps(self, bugs): | ||
| def handler(bug, data): | ||
| if bug["resolution"] == "": |
There was a problem hiding this comment.
Maybe you could filter out closed bugs at query time directly
marco-c
approved these changes
Feb 8, 2021
|
@calixteman ping |
marco-c
requested changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It aims to fix the issue reported by bz last week.