-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Buildhub2 (#6) #7
Conversation
This switches build data acquisition to use Buildhub2.
How curious--the tests seem to pass locally. I'll look into the buildhub ones. I think at least one of them is because release candidate builds have the same version as the final release, so if you request by version string, then you get multiple build ids.
|
Some things were escaped for Python strings, but since I made the strings raw strings, we don't need the Python string escapes anymore.
^^^ That fixes all the tests. I had run them, everything passed, then hit linting errors, fixed the linting errors by making the strings raw strings but forgot to look at the escapes and remove the Python string escapes. Bah. |
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=========================================
Coverage ? 21.79%
=========================================
Files ? 24
Lines ? 2202
Branches ? 396
=========================================
Hits ? 480
Misses ? 1702
Partials ? 20
Continue to review full report at Codecov.
|
@willkg thx, I'll have look asap |
This switches build data acquisition to use Buildhub2.
I was able to run the tests, but I wasn't able to run the app. It needs a database and I don't have that set up locally. But based on other migrations I've done, I think this will work.
Fixes #6.