feat(transport): Use a shorter ECN probe threshold initially #3239
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: CI | |
| on: | |
| push: | |
| branches: ["main"] | |
| paths-ignore: ["*.md", "*.png", "*.svg", "LICENSE-*"] | |
| pull_request: | |
| branches: ["main"] | |
| paths-ignore: ["*.md", "*.png", "*.svg", "LICENSE-*"] | |
| merge_group: | |
| env: | |
| CARGO_TERM_COLOR: always | |
| RUST_BACKTRACE: 1 | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.ref_name }} | |
| cancel-in-progress: true | |
| permissions: read-all | |
| jobs: | |
| check: | |
| name: Build & test | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| os: [ubuntu-latest, macos-14, windows-latest] | |
| # Don't increase beyond what Firefox is currently using: | |
| # https://searchfox.org/mozilla-central/search?q=MINIMUM_RUST_VERSION&path=python/mozboot/mozboot/util.py | |
| # Keep in sync with Cargo.toml | |
| rust-toolchain: [1.76.0, stable, nightly] | |
| type: [debug] | |
| include: | |
| - os: ubuntu-latest | |
| rust-toolchain: stable | |
| type: release | |
| env: | |
| BUILD_TYPE: ${{ matrix.type == 'release' && '--release' || '' }} | |
| runs-on: ${{ matrix.os }} | |
| defaults: | |
| run: | |
| shell: bash | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 | |
| - name: Install dependencies (Linux) | |
| if: runner.os == 'Linux' | |
| env: | |
| DEBIAN_FRONTEND: noninteractive | |
| run: | | |
| sudo apt-get install -y --no-install-recommends gyp mercurial ninja-build lld | |
| echo "RUSTFLAGS=-C link-arg=-fuse-ld=lld" >> "$GITHUB_ENV" | |
| - name: Install dependencies (MacOS) | |
| if: runner.os == 'MacOS' | |
| run: | | |
| brew update | |
| brew install llvm nss | |
| echo "/opt/homebrew/opt/llvm/bin" >> "$GITHUB_PATH" | |
| echo "RUSTFLAGS=-C link-arg=-fuse-ld=lld" >> "$GITHUB_ENV" | |
| - name: Install dependencies (Windows) | |
| if: runner.os == 'Windows' | |
| run: | | |
| # shellcheck disable=SC2028 | |
| { | |
| echo C:/msys64/usr/bin | |
| echo C:/msys64/mingw64/bin | |
| } >> "$GITHUB_PATH" | |
| /c/msys64/usr/bin/pacman -S --noconfirm nsinstall | |
| echo "gyp-next==0.15.0 --hash=sha256:3600f2a80fa33d3574f51bbb3d4bfc843373dafbe84059958aea3f1c9560f95a" > requirements.txt | |
| python3 -m pip install --require-hashes -r requirements.txt | |
| echo "$(python3 -m site --user-base)/bin" >> "$GITHUB_PATH" | |
| - name: Set up MSVC build environment (Windows) | |
| if: runner.os == 'Windows' | |
| uses: ilammy/msvc-dev-cmd@v1 | |
| # TODO: Would like to pin this, but the Mozilla org allowlist requires "ilammy/msvc-dev-cmd@v1*" | |
| # uses: ilammy/msvc-dev-cmd@0b201ec74fa43914dc39ae48a89fd1d8cb592756 # v1.13.0 | |
| - name: Set up NSS/NSPR build environment (Windows) | |
| if: runner.os == 'Windows' | |
| run: | | |
| { | |
| echo "GYP_MSVS_OVERRIDE_PATH=$VSINSTALLDIR" | |
| echo "GYP_MSVS_VERSION=2022" | |
| echo "BASH=$SHELL" | |
| } >> "$GITHUB_ENV" | |
| # See https://github.com/ilammy/msvc-dev-cmd#name-conflicts-with-shell-bash | |
| rm /usr/bin/link.exe | |
| - name: Install Rust | |
| uses: ./.github/actions/rust | |
| with: | |
| version: ${{ matrix.rust-toolchain }} | |
| components: rustfmt, clippy, llvm-tools-preview | |
| - name: Fetch and build NSS and NSPR | |
| uses: ./.github/actions/nss | |
| - name: Build | |
| run: | | |
| # shellcheck disable=SC2086 | |
| cargo +${{ matrix.rust-toolchain }} build $BUILD_TYPE --all-targets --features ci | |
| - name: Run tests and determine coverage | |
| run: | | |
| # shellcheck disable=SC2086 | |
| RUST_LOG=trace cargo +${{ matrix.rust-toolchain }} llvm-cov nextest $BUILD_TYPE --features ci --no-fail-fast --lcov --output-path lcov.info | |
| cargo +${{ matrix.rust-toolchain }} bench --features bench --no-run | |
| - name: Run client/server transfer | |
| run: | | |
| # shellcheck disable=SC2086 | |
| cargo +${{ matrix.rust-toolchain }} build $BUILD_TYPE --bin neqo-client --bin neqo-server | |
| "target/$BUILD_DIR/neqo-server" "$HOST:4433" & | |
| PID=$! | |
| # Give the server time to start. | |
| sleep 1 | |
| "target/$BUILD_DIR/neqo-client" --output-dir . "https://$HOST:4433/$SIZE" | |
| kill $PID | |
| [ "$(wc -c <"$SIZE")" -eq "$SIZE" ] || exit 1 | |
| env: | |
| HOST: localhost | |
| SIZE: 54321 | |
| RUST_LOG: warn | |
| BUILD_DIR: ${{ matrix.type == 'release' && 'release' || 'debug' }} | |
| - name: Check formatting | |
| run: | | |
| if [ "${{ matrix.rust-toolchain }}" != "nightly" ]; then | |
| CONFIG_PATH="--config-path=$(mktemp)" | |
| fi | |
| # shellcheck disable=SC2086 | |
| cargo +${{ matrix.rust-toolchain }} fmt --all -- --check $CONFIG_PATH | |
| if: success() || failure() | |
| - name: Check for unused dependencies | |
| run: | | |
| # --with-metadata has false positives, see https://github.com/bnjbvr/cargo-machete/issues/127 | |
| cargo +${{ matrix.rust-toolchain }} machete | |
| - name: Clippy | |
| run: | | |
| # Use cargo-hack to run clippy on each crate individually with its | |
| # respective default features only. Can reveal warnings otherwise | |
| # hidden given that a plain cargo clippy combines all features of the | |
| # workspace. See e.g. https://github.com/mozilla/neqo/pull/1695. | |
| cargo +${{ matrix.rust-toolchain }} hack clippy --all-targets --feature-powerset --exclude-features gecko -- -D warnings || ${{ matrix.rust-toolchain == 'nightly' }} | |
| # Check that the fuzz targets also build | |
| if [ ${{ matrix.rust-toolchain }} == 'nightly' ]; then | |
| cargo +${{ matrix.rust-toolchain }} fuzz check | |
| fi | |
| if: success() || failure() | |
| - name: Check rustdoc links | |
| run: cargo +${{ matrix.rust-toolchain }} doc --workspace --no-deps --document-private-items | |
| env: | |
| RUSTDOCFLAGS: "--deny rustdoc::broken_intra_doc_links --deny warnings" | |
| if: success() || failure() | |
| - name: Upload coverage reports to Codecov | |
| uses: codecov/codecov-action@e28ff129e5465c2c0dcc6f003fc735cb6ae0c673 # v4.5.0 | |
| with: | |
| file: lcov.info | |
| fail_ci_if_error: false | |
| token: ${{ secrets.CODECOV_TOKEN }} | |
| verbose: true | |
| if: matrix.type == 'debug' && matrix.rust-toolchain == 'stable' | |
| bench: | |
| name: "Benchmark" | |
| needs: [check] | |
| uses: ./.github/workflows/bench.yml |