Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FedCM Update #1104

Merged
merged 1 commit into from
Dec 6, 2024
Merged

FedCM Update #1104

merged 1 commit into from
Dec 6, 2024

Conversation

bvandersloot-mozilla
Copy link
Contributor

It's been a couple years. This should be a good update.

@martinthomson is a good person to review and merge!

Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the linked issue #618 and didn't see any discussion regarding the change in position from "positive" to "neutral". Could you add a comment there with the updated analysis (or link if elsewhere) that led to the new "neutral" position?

@bvandersloot-mozilla
Copy link
Contributor Author

@tantek: I've added a comment with some updated analysis in #618. I also updated the URL so it doesn't rely on a redirect. It recently published a FPWD in a WG, but has a lot of issues to close before it becomes a CR. Should I leave the org as "Proposal" or update to "W3C"?

activities.json Outdated Show resolved Hide resolved
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, change org to W3C, and similarly, if you could update the mozPositionDetail with a summary of the comment you made on #618 that would help provide a self-contained update of why we are changing the position to "neutral". Otherwise from an outside perspective it's not obvious (without hunting/clicking) why position changed.

@zcorpan
Copy link
Member

zcorpan commented Dec 2, 2024

I've rebased this so that it edits activities.yml instead, and added "W3C" per @tantek 's comment. I haven't changed the rationale as @tantek requested, leaving that to @bvandersloot-mozilla

@bvandersloot-mozilla
Copy link
Contributor Author

I have already updated rationale with a summary of that comment. mozPositionDetail got refactored to that IIRC.

@zcorpan zcorpan requested a review from tantek December 5, 2024 11:11
Copy link
Member

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this critical update.

@tantek tantek merged commit f991732 into mozilla:main Dec 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants