-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New endpoint to create internal issues before submitting a bug #8443
Changes from 3 commits
c13eb80
4a7e328
894f43d
dde6d9d
8110f66
bd3ad10
e38442f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import django.db.models.deletion | ||
from django.conf import settings | ||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
("model", "0035_bugscache_optional_bugzilla_ref"), | ||
migrations.swappable_dependency(settings.AUTH_USER_MODEL), | ||
] | ||
|
||
operations = [ | ||
migrations.RemoveConstraint( | ||
model_name="bugscacheoccurrence", | ||
name="unique_failureline_bug_occurrence", | ||
), | ||
migrations.RemoveField( | ||
model_name="bugscacheoccurrence", | ||
name="failure_line", | ||
), | ||
migrations.AddField( | ||
model_name="bugscacheoccurrence", | ||
name="text_log_error", | ||
field=models.ForeignKey( | ||
on_delete=django.db.models.deletion.CASCADE, | ||
related_name="bug_occurrences", | ||
to="model.textlogerror", | ||
), | ||
), | ||
migrations.AddConstraint( | ||
model_name="bugscacheoccurrence", | ||
constraint=models.UniqueConstraint( | ||
fields=("text_log_error", "bug"), | ||
name="unique_text_log_error_bug_occurrence", | ||
), | ||
), | ||
] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
from datetime import timedelta | ||
|
||
from django.db import transaction | ||
from django.utils import timezone | ||
from rest_framework import generics, serializers | ||
|
||
from treeherder.model.models import Bugscache, FailureLine | ||
|
||
# Only track occurrences of a bug on a specific time window | ||
BUGSCACHE_OCCURENCES_WINDOW = timedelta(days=7) | ||
vrigal marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
|
||
class InternalIssueSerializer(serializers.Serializer): | ||
failure_line_id = serializers.PrimaryKeyRelatedField( | ||
write_only=True, | ||
source="failure_line", | ||
queryset=FailureLine.objects.all(), | ||
) | ||
occurrences = serializers.SerializerMethodField(read_only=True) | ||
|
||
def get_occurrences(self, bug): | ||
return bug.occurrences.filter(created__gte=timezone.now() - BUGSCACHE_OCCURENCES_WINDOW) | ||
|
||
@transaction.atomic | ||
def create(self, validated_data): | ||
failure_line = validated_data["failure_line"] | ||
|
||
# TODO: Fetch all the similar failure lines | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For awareness and understanding: In general, the failure lines classified with an internal issue will be similar but they could also be different because they have a common root cause which is not logged in the failure line, e.g. a random focus issue of the browser engine or test framework can cause various form tests to fail. The canonical source for occurrences remain the classifications from Bugscache. |
||
similar_failure_lines = [failure_line.id] | ||
|
||
# Build or retrieve a bug already reported for a similar FailureLine | ||
bug = Bugscache.objects.filter(occurrences__failure_line__in=similar_failure_lines).first() | ||
if bug is None: | ||
# TODO: Support writting summary field from the FailureLine information | ||
bug = Bugscache.objects.create() | ||
|
||
bug.occurrences.get_or_create( | ||
user=self.context["request"].user, | ||
failure_line=failure_line, | ||
bug=bug, | ||
) | ||
return bug | ||
|
||
class Meta: | ||
model = Bugscache | ||
fields = ["failure_line_id", "occurrences"] | ||
|
||
|
||
class CreateInternalIssue(generics.CreateAPIView): | ||
""" | ||
Create a Bugscache entry, not necessarilly linked to a real Bugzilla ticket. | ||
In case it already exists, update its occurrences. | ||
|
||
Returns the number of occurrences of this bug in the last week. | ||
""" | ||
|
||
serializer_class = InternalIssueSerializer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Treeherder stores classifications of jobs (tasks) with bugs (internal issues in the future) which get suggested for failure lines. Based on the discussion last week, I think we should keep that concept.
The unique combination should job + internal issue ID.