Fix some more Swift concurrency issues #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhammond
approved these changes
Oct 31, 2024
bendk
force-pushed
the
push-wsnlxtoqmvxy
branch
from
a3032a3 to
fa74fae
Compare
Converted some more vars to lets. Swift still complains about async calls. I believe the next step would be to make all UniFFI objects conform to `Sendable`. Split the `FfiType::Reference` variant into `Reference` and `MutReference`. This allows us to define some more variables using `let` in swift. See mozilla#2279.
bendk
force-pushed
the
push-wsnlxtoqmvxy
branch
from
fa74fae to
2b05c3d
Compare
|
These seem safe enough to me, I'm going to go ahead and merge them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted some more vars to lets. Swift still complains about async calls. I believe the next step would be to make all UniFFI objects conform to
Sendable.See #2279.