DVB fixes (slow hardware, VDR channels.conf) #6835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While they accept the frequency field with MHz for DVB-S, for DVB-C and DVB-T, it may be in Hz, kHz or MHz. The official rule is to multiply whatever is in the channels.conf by 1000 until a value > 1000000 is reached to get correct units for tuning.
It seems some DVB-T2 cards take longer to push out data.
|
2 seconds could be a bit long, but we anyways at the previous maximum would have waited until 2.5 seconds (500ms * 5). This now gets bumped to 10 seconds (2000ms * 5). |
Indeed. I was really astonished that the DVB-T hardware mentioned in the linked thread was too slow and did not deliver any data in 2.5 seconds, which I already considered to be rather long - but bumping that has helped the user, who could not tune at all (and also my DVB-S card takes a second or so until first data arrives). Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion in #6372 has highlighted two issues which are fixed in this commit series:
channels.confis rather flexible about units for the frequency (it accepts Hz, kHz and MHz). We now do as VDR does and multiply the value provided in the config file by 1000 until 1000000 is reached. This fixes compatibility especially with more recentchannels.conffiles.I agree that my changes can be relicensed to LGPL 2.1 or later.
Thanks to @berndbb both for finding the issues and for testing my fixes on his HW!