Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes require.resolve with paths property #56

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fixes require.resolve with paths property #56

merged 1 commit into from
Jul 9, 2024

Conversation

mhassan1
Copy link
Collaborator

@mhassan1 mhassan1 commented Jul 9, 2024

This PR fixes the require.resolve call that was introduced in #17; the options argument should be an object.

Resolves #55.

@mhassan1 mhassan1 marked this pull request as ready for review July 9, 2024 16:59
@mhassan1 mhassan1 requested a review from romainmenke July 9, 2024 17:00
romainmenke
romainmenke approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@mhassan1 mhassan1 enabled auto-merge (squash) July 9, 2024 17:04
@mhassan1 mhassan1 merged commit c05a288 into main Jul 9, 2024
17 checks passed
@mhassan1 mhassan1 deleted the require-resolve-paths branch July 9, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainmenke romainmenke romainmenke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Polyfill devDependencies should be resolved from polyfills/*
2 participants
@mhassan1 @romainmenke