Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update NewtonSoft Json to 6.0.2 #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

webcoyote
Copy link
Collaborator

Updated package config and project files to use Newtonsoft.JSON v6.0.2 instead of 5.0.3

@mroach
Copy link
Owner

mroach commented Jul 30, 2014

It is a mistake for RollbarSharp.Mvc4Test to be referencing a different version of Json.Net than the main project, however I'd like to leave it at 5.0.3 since the nuget package only requires 5.0 as a minimum version. I wouldn't want to require RollbarSharp users to upgrade to 6.0 unless there's a compelling reason. What do you think?

@webcoyote
Copy link
Collaborator Author

Version 6.0.2 of NewtonSoft Json appears to have a lot of bug-fixes over 5.x.x (listed here https://json.codeplex.com/releases/view/117958 and https://json.codeplex.com/releases/view/121470); while I haven't actually encountered any of those bugs I'm loathe to roll back. In fact I'll probably update my branch to use 6.0.3 shortly since there are even more fixes (https://json.codeplex.com/releases/view/121470).

I'll keep using my fork of RollbarSharp which includes the more recent version of Json, and you can close this pull request without merging if you think that's the right thing to do.

@mroach
Copy link
Owner

mroach commented Nov 10, 2014

@webcoyote If your project is already using 6.x, does nuget still try to force you to install 5.x?

@webcoyote
Copy link
Collaborator Author

@mroach Nope; when I build it only gets 6.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants