Drop support for MySQL 5.7 #84
Conversation
.github/workflows/build.yml
Outdated
| tags="${tags},groonga/mroonga:latest" | ||
| fi | ||
| echo "::set-output name=push::${push}" | ||
| echo "::set-output name=tags::${tags}" | ||
| - uses: actions/checkout@v4 | ||
| - uses: docker/login-action@v3 | ||
| if: ${{ steps.parse.outputs.push }} == 'true' |
There was a problem hiding this comment.
| if: ${{ steps.parse.outputs.push }} == 'true' | |
| if: steps.parse.outputs.push == 'true' |
| tags="${tags},groonga/mroonga:latest" | ||
| fi | ||
| echo "::set-output name=push::${push}" | ||
| echo "::set-output name=tags::${tags}" | ||
| - uses: actions/checkout@v4 | ||
| - uses: docker/login-action@v3 | ||
| if: steps.parse.outputs.push == 'true' |
There was a problem hiding this comment.
GITHUB_EVENT_NAMEがpushのときだけsteps.parse.outputs.pushをtrueにしてくれる？
| ;; | ||
| *) | ||
| version=${{ matrix.id }}-latest | ||
| push=false |
There was a problem hiding this comment.
これをがんばらない方がいいのかな。
たぶん、タグとpushしたコミットの両方でpushするとエラーになるからこうしているんだと思うんだけど、それを無視すればいいっちゃいいんだよね。気持ち悪いけど。
.github/workflows/build.yml
Outdated
| case "${{ github.ref }}" in | ||
| refs/tags/*) | ||
| version=$(echo "${{ github.ref }}" | sed -e "s,^refs/tags/,,g") | ||
| version="${{ github.ref_name }}" |
There was a problem hiding this comment.
これもやっちゃうならcase "${{ github.ref }}" inも直しちゃう？
if [ "${GITHUB_REF_TYPE}" = "tag" ] -a [[ "${GITHUB_REF_NAME}" =~ "^${{ matrix.id }}\." ]]; then
version="${GITHUB_REF_NAME}"
else
version=${{ matrix.id }}-latest
fiThere was a problem hiding this comment.
bashで正規表現メモ
パターンを " で囲むと正規表現として扱われないらしい。
$ bash -c '[[ "hoge.2" =~ ^hoge\. ]] && echo "true"'
true
$ bash -c '[[ "hoge.2" =~ "^hoge\." ]] && echo "true"'
# （出力なし）
.github/workflows/build.yml
Outdated
| ;; | ||
| esac | ||
|
|
||
| push=false | ||
| if [[ "${{ github.event_name }}" = "push" ]]; then |
There was a problem hiding this comment.
シェルスクリプトの中では${{ github.XXX }}より${GITHUB_XXX}を使って欲しい。評価タイミングが揃うから。
| esac | ||
| fi | ||
| else | ||
| version=${{ matrix.id }}-latest |
There was a problem hiding this comment.
タグじゃない"${GITHUB_EVENT_NAME}" = "push"のときはpush=trueして欲しい。
.github/workflows/build.yml
Outdated
| if [ "${GITHUB_EVENT_NAME}" = "push" ] && [ "${GITHUB_REF_TYPE}" != "tag" ]; then | ||
| push=true | ||
| fi |
There was a problem hiding this comment.
これだとmysql-8.0.30-12.06とかのイメージがpushされなくない？
There was a problem hiding this comment.
タシカニ…。脳みそがおつかれなので、復活してから整理します…。
.github/workflows/build.yml
Outdated
| esac | ||
| if [ "${GITHUB_EVENT_NAME}" = "push" ]; then | ||
| push=true | ||
| if [ "${GITHUB_REF_TYPE}" = "tag" ] && [[ !("${GITHUB_REF_NAME}" =~ ^${{ matrix.id }}\.) ]]; then |
There was a problem hiding this comment.
bashで正規表現を何回も使うのはしんどいのでこんなんでいけないかな。
| if [ "${GITHUB_REF_TYPE}" = "tag" ] && [[ !("${GITHUB_REF_NAME}" =~ ^${{ matrix.id }}\.) ]]; then | |
| if [ "${GITHUB_REF_TYPE}" = "tag" ] && [ "${version}" != "${GITHUB_REF_NAME}” ]; then |
There was a problem hiding this comment.
タシカニ。$version を見る発想はあったんですが、-latest の有無で判断すべきという思考から抜け出せなかったです…。
We also tidied up the conditions for docker push with CI.