Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix optional parameters in callbacks #143

Merged
merged 4 commits into from
Sep 23, 2024
Merged

fix: Fix optional parameters in callbacks #143

merged 4 commits into from
Sep 23, 2024

Conversation

mrousavy
Copy link
Owner

@mrousavy mrousavy commented Sep 23, 2024 •
edited
Loading

Fixes an issue where nullable/optional parameters were not optional/nullable in the generated specs.

something(callback: (value: number | undefined) => void): void

@mrousavy mrousavy changed the title feat: Add optional callback tests fix: Fix optional parameters in callbacks Sep 23, 2024
This was referenced Sep 23, 2024
Closed
Closed
@mrousavy mrousavy merged commit 98d1c15 into main Sep 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

callback with optional parameters do not generate nullable parameters Nitrogen is not respecting optionals
1 participant
@mrousavy