fix: Remove unused args
parameter in createHybridObject(..)
#145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter was unused anyways, so remove it.
Hybrid Objects that can be default-constructed using
createHybridObject(..)
should not take any arguments anyways, as this just overly complicates things (how do we parse the args? Do we convert them to Swift/Kotlin types? How do we length-check them? It needs to be compile-time, etc), as well as potentially uses unsafe typings (we are not in a Nitro context yet so we cannot use the JSIConverter template stuff).If you need arguments here, create a default-constructible "factory" HybridObject first, then create your other HybridObjects from that factory with some helper methods - those are fast, type-safe, and compile-time generated.