Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Nitro Views!!!!!!!!! 🥳 #512

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

feat: Nitro Views!!!!!!!!! 🥳 #512

wants to merge 32 commits into from

Conversation

mrousavy
Copy link
Owner

@mrousavy mrousavy commented Jan 23, 2025 •
edited
Loading

What

Screen.Recording.2025-01-23.at.14.41.12.mov
  • Updates example to react-native 0.78.0-rc.1
  • (RN Screens and RN Safe Area need local patches as they break on RN 78 for now)
  • Updates the Hybrid View to blue light effect
  • Add example for views

Changes

  • Fixes Nitro Views to properly produce code that compiles on Fabric 0.78
  • Fixes boolean getters that start with is not properly compiling (the Swift/Kotlin compiler changes the name for those props, isBlue -> isBlue() vs getIsBlue())

Blockers

  • react-native-safe-area-context breaks on RN 0.78-rc.0 (fixed in a recent beta)
  • react-native-screens breaks on RN 0.78-rc.0 (waiting for beta)

@vercel Vercel
Copy link

vercel bot commented Jan 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nitro-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 5:31pm

@mrousavy mrousavy changed the title feat: Upgrade to react-native 0.78 feat: Nitro Views!!!!!!!!! Jan 23, 2025
@mrousavy mrousavy changed the title feat: Nitro Views!!!!!!!!! feat: Nitro Views!!!!!!!!! 🥳 Jan 23, 2025
@mrousavy
Copy link
Owner Author

Android works as well! 🥳

Screen.Recording.2025-01-23.at.17.43.09.mov

mrousavy added 27 commits February 3, 2025 18:30
@mrousavy
feat: Create View Screen
2e16007
@mrousavy
feat: Add Views logo
18a7484
@mrousavy
feat: Actually render the view
afb84ac
@mrousavy
feat: It extends ViewProps
34269a8
@mrousavy
feat: Style it better
6f43dde
@mrousavy
Blue light :)
ef85c97
@mrousavy
fix: Separate border and shadow
395d3cb
@mrousavy
fix: Set Folly flags
57de38f
@mrousavy
fix: Fix build for Android by tweaking state getter
7c394ee
@mrousavy
WOOOHOOO IT WORKS ON ANDROID!!!!!!
0a65fd7
@mrousavy
background color in android?
fdd6669
@mrousavy
chore: Rename to isBlue
0110bc2
@mrousavy
Update ViewScreen.tsx
4b30b47
@mrousavy
fix: isX for boolean getters
f748fdc
@mrousavy
fix: Also register view component in J View
2ed9ac0
@mrousavy
Revert "fix: isX for boolean getters"
437c542 
This reverts commit 1ce5f31.
@mrousavy
feat: Pass environment to setter names
2a2ecfc
@mrousavy
fix: Fix stupid kotlin props being prefixed differently
6067694
@mrousavy
Update HybridTestView.kt
94c9883
@mrousavy
feat: Add beforeUpdate() and afterUpdate() to Android
ec27f89
@mrousavy
indent
20fe7d1
@mrousavy
feat: Unmount custom view when navigating away
9c992d9
@mrousavy
perf: Only override adopt() on Android
de343bd
@mrousavy
perf: Make state updater internal
9317123
@mrousavy
add button to start/stop updating props
ef4c6bb
@mrousavy
Add infinite mount example
0a6b2e9
@mrousavy
chore: Rebuild lockfiles
8488a6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannojg hannojg hannojg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrousavy @hannojg