use webpack`s public path at runtime to resolve sprite url #110

ggarek · 2016-09-01T14:25:17Z

fix issue #109

chicoxyzzy · 2016-11-09T14:57:59Z

@mrsum @lgordey can you guys take a look please? We really need this

mrsum · 2016-11-10T08:51:44Z

@chicoxyzzy got it

mrsum · 2016-11-10T08:52:55Z

@ggarek @chicoxyzzy sorry for delay guys, can some one bump version into package.json to 3.0.5

chicoxyzzy · 2016-11-10T10:18:58Z

This change introduces breaking change as mentioned in #109. So it shouldn't be 3.0.5 if you follow SemVer 😃

ggarek · 2016-11-10T10:21:48Z

@chicoxyzzy that's right
@mrsum moreover before applying the change some more work should be done, considering it is a breaking change. (i mean the window.baseUrl magic)

use webpack`s public path at runtime to resolve sprite url

37880b3

mrsum merged commit 9a49bd2 into mrsum:develop Nov 11, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use webpack`s public path at runtime to resolve sprite url #110

use webpack`s public path at runtime to resolve sprite url #110

ggarek commented Sep 1, 2016 •

edited

Loading

chicoxyzzy commented Nov 9, 2016

mrsum commented Nov 10, 2016

mrsum commented Nov 10, 2016

chicoxyzzy commented Nov 10, 2016

ggarek commented Nov 10, 2016 •

edited

Loading

use webpack`s public path at runtime to resolve sprite url #110

use webpack`s public path at runtime to resolve sprite url #110

Conversation

ggarek commented Sep 1, 2016 • edited Loading

chicoxyzzy commented Nov 9, 2016

mrsum commented Nov 10, 2016

mrsum commented Nov 10, 2016

chicoxyzzy commented Nov 10, 2016

ggarek commented Nov 10, 2016 • edited Loading

ggarek commented Sep 1, 2016 •

edited

Loading

ggarek commented Nov 10, 2016 •

edited

Loading