Added windows 10 support and cleaned up some formatting. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs to be tested for a stock windows install, without a linux subsystem color support. But, it works for now.
Alright, this one should add native windows 10 support. Changed escape codes from \033 to \x1b to add cmd.exe support, and everything should now work in powershell and win 10 releases, as long as it's past 1703.
used friggin && instead of and
|
Here's an image of it working on my VM. |
|
thank you 😊 i will merge this in after i finish the “smooth print” thing from another issue. |
wrencrt
commented
Jul 2, 2020
gay.py
Outdated
| @@ -251,7 +250,7 @@ def decor_24(rgb: RGB) -> Iterator[str]: | |||
|
|
|||
| def decor_for(space: ColourSpace) -> Tuple[str, str, Callable[[RGB], Iterator[str]]]: | |||
| if space == ColourSpace.EIGHT or WindowsColorTerm == True: | |||
| return "\x1b[38;5;", "\x1b[48;5;", decor_8 | |||
There was a problem hiding this comment.
2 characters, seriously. that's all this changes.
|
I still need someone to test this for me, as my testing may not have been complete. |
ms-jpq
reviewed
Jul 2, 2020
|
@wrennnnnn I just updated the code to work with the new microsoft terminal. It doesn't work with the old I guess maybe my version of Windows might be too old though, I havn't patched my VM in a while.
You can try running my branch against your local machine, and if you are happy we can close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.