Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will need to update environment_schema.json to make 'name' field not mandatory #142

Open
rnaidu opened this issue Sep 6, 2024 · 1 comment · Fixed by #143
Open

Will need to update environment_schema.json to make 'name' field not mandatory #142

rnaidu opened this issue Sep 6, 2024 · 1 comment · Fixed by #143
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@rnaidu
Copy link
Collaborator

rnaidu commented Sep 6, 2024

Saw on nf-core slack that a new change was introduced today which throws an error if the user has a 'name' field in their module's environment.yml. the MSK environment_schema.json requires a 'name' field, so this will need to be made optional to account for this change.

@rnaidu rnaidu added the question Further information is requested label Sep 6, 2024
@rnaidu rnaidu self-assigned this Sep 6, 2024
@rnaidu rnaidu linked a pull request Sep 6, 2024 that will close this issue
3 tasks
@rnaidu rnaidu added the bug Something isn't working label Sep 6, 2024
@buehlere
Copy link
Collaborator

buehlere commented Oct 3, 2024

NF-core lint requires the schema to be updated but verify markdown uses the older schema, so this needs to wait until we decide on a schema

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants