-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'name' field as mandatory from environment_schema.json #143
Conversation
… updated nf-core lint functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking about this in two ways.
Either we just merge in the schema change and let people fix their individual modules when they see the lint failing. Or we could just go ahead and remove the name
field all modules.
I think both should be pretty easy. I'm leaning towards just removing it for all modules.
I also noticed defaults
is being removed is that part of the linting update?
@buehlere I agree on removing 'name' for all modules, since the conversation on the nf-core slack said the 'name' field will be removed from the new module template moving forward. I'll add that change now I think removing 'defaults' is part of the linting update as well since I updated my nf-core and used this command to create a module off the updated nf-core modules template. The new module created by the updated template has both 'name' and 'defaults' removed. I reached out to the nf-core maintainer in that slack thread in case we want a confirmation from them before merging the schema.
|
e6dfbfa
to
bf219c9
Compare
…nting update. Users will have to edit current module environment.yml files accordingly. future modules downloaded by nf-core will follow configuration set in this environment_schema.json
Final environment_schema.json includes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
PR checklist
Closes #142