-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add miniflare environment regression test #1840
Conversation
@@ -0,0 +1,75 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a copy of other tests for now, but may get further scoped in the future, or w can write a small cloudflare handler to validate (which would be ideal).
For now, this just throws on the property access we expect it to, a least
Just tested this with #1845 and updated
🎉 |
054e2bf
to
c93e93e
Compare
Updated the branch. Waiting for the tests to pass... Edit: Looks like we pushed the merge commit at the exact same time, @mattcosta7! :D That's fun. |
oh nice! I realized that I had a different version of the lock file checked in, so downgraded pnpm locally and repushed that too |
@mattcosta7, you are once again, a true wizard. Thank you so much. |
Released: v2.0.5 🎉This has been released in v2.0.5! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
This was a failing test for the miniflare environment as discussed in #1834
Now that related changes to interceptors and cookies have shipped, and we have upgraded versions this test is green, and provides a regression check on future changes
The original error was something like this: