Sync with v0.13.0 Beta 2 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My file change corrects a typo in the document. Best, Hou
Translate 'Note' to '注意' instead of '提示' to make it more sensible.
Eliminate context warnings when component isn't reading the conflicting context variable
This allows state to be set up in the constructor instead of through getInitialState. getInitialState is now considered part of "classic". Therefore, they move into ReactClass's constructor. As a consequence of this, we no longer have a mapping between the internal representation and the public instance during the mounting process. Because the constructor hasn't returned yet. We used to have a special case for calling setState in getInitialState which was just ignored. This makes that throw and the component is considered unmounted during the construction phase.
New class instantiation and initialization process
document.createElement throws an error if you don't pass it any arguments. Neither PhantomJS nor jest (via jsdom at version jest is using) behave as browsers do now so this went unnoticed.
Add Chinese translation to several pages.
Update 03-interactivity-and-dynamic-uis.md: correct typo
This will at least make the examples run while we fix the issue.
Temporarily comment out bundle-collapser for JSXTransformer
This is basically a copy of ReactDOMImg
Update ReactDefaultPerf to properly record component names.
Repair ReactDefaultPerf
Conflicts: docs/_data/nav_tips.yml docs/tips/17-children-undefined.md
Summary: If `getDOMNode()` returns null in `LocalEventTrapMixin`, `listener` will also be null and `accumulateInto` will throw. This changes `LocalEventTrapMixin` to throw a more helpful error message. Test Plan: Ran unit test successfully: ``` npm test LocalEventTrapMixin-test.js ```
Fix LocalEventTrapMixin for Bad Tree State
The string here was initially accurate, but got out of sync with reality when the commit was revised (as 892e357).
This excerpt adds the onSubmit handler to the form element, but the line was not highlighted as having been modified.
It's a "shortcut" to `grunt build`
Fix inaccurate spec description
Update 02.1-jsx-in-depth.md
Correctly highlight changed line in tutorial.
…slySetInnerHtml Document justification for dangerouslySetInnerHTML, fixes facebook#2256
This will be based on the site generation time, making doc generation slightly less deterministic but that's ok. Now we won't depend on helpful community members updating it for us (facebook#2874) when we forget, it'll just happen naturally the next time the site is generated.
…slation Update documents for Chinese translation
This ensures that we have a prefix that can be easily identified in logs so that we can filter out warnings based on their prefix. This also turns the remaining two monitorCodeUse callers into warnings. We'll probably still use monitorCodeUse until we know if we want to deprecate but most releases should only have warnings.
Moar warnings with solid prefixes!
More lint rules, fixes
safe_yaml 1.0.3 has some issues with Ruby 2.2.0: dtao/safe_yaml#67
Conflicts: src/browser/ui/ReactDOMIDOperations.js src/browser/ui/dom/Danger.js
Fix for the jekyll docs build process
ESLint coverage
Only monitor components that are likely stateful (inputs and composites)
Update jsx binary to latest jstransform + latest flow syntax features
Fixed Copyright year for three files and react.js licence to BSD-license
Dedupe owner-is-important warning.
Add missing condition from original polyfill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.