Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the canvas size instead of the image #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change the canvas size instead of the image #91

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 28, 2016

This is a solution of this problem: github.com/multani/sonata/issues/90.

sonata/img.py: composite_case: change the canvas size instead of
8a388e0 
the image. This is solution of this issue: #90.
@ghost ghost changed the title Change size of the image instead of the canvas Change the image size instead of the canvas Feb 28, 2016
@ghost ghost changed the title Change the image size instead of the canvas Change the canvas size instead of the image Feb 28, 2016
@multani
Copy link
Owner

multani commented Apr 13, 2016

Hi @kalterfive,

Sorry for the (very late) reply. That look good to me, but I was thinking: why do we reduce the image size, instead of increasing the image + spine size.

So, instead of having the whole width to be total_width = spine_width + (image_width - spine_width), why don't we have instead total_width = spine_width + image_width
Then, we don't resize the original image and we also don't crop it (by removing the part for the spine thing).
What do you think? Would you give it a try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@multani