Improve YouTube API error handling #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance YouTube API service with comprehensive error handling, retries, and logging to improve reliability. Add typed YouTubeError interface, implement exponential backoff with jitter, properly handle rate limits (429) and quota exceeded (403), and improve cache key management.
📦 🤖 A new release has been made for this pull request.To play around with this PR, pull Images are available for x86_64 and ARM64.
|
lint 2
lint 3
lint 4
lint 5
lint 5
|
Addressed type and linting errors. All checks passing. Tested changes locally. Ready for review :) |
JoeWHoward
reviewed
Jan 27, 2025
| const error = new Error(message) as YouTubeError; | ||
| error.code = code; | ||
| error.status = status; | ||
| error.retryable = code === 'NETWORK_ERROR' || (status ? status >= 500 : false); |
There was a problem hiding this comment.
Should we treat HTTP 403 as retry-able?
There was a problem hiding this comment.
A 403 forbidden generally won't resolve with a retry, since it's due to invalid API key, geo restriction, or exceeding daily API quota
JoeWHoward
approved these changes
Jan 27, 2025
shiftybitshiftr
added a commit
that referenced
this pull request
Jan 28, 2025
This reverts commit 373e6a5.
shiftybitshiftr
added a commit
that referenced
this pull request
Jan 28, 2025
|
🚀 Released in Release v2.10.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances how the bot handles YouTube API issues by adding better error handling, retries, and user feedback. The main improvements are:
YouTubeErrorinterfaceI updated
youtube-api.ts, centralizing error handling in a newexecuteYouTubeRequestmethod that all YouTube API calls use. This makes our error handling more consistent and makes the bot more resilient to API issues.Users will now see clearer messages like:
Testing Notes
The key things to test are:
Thanks!