Fix Issue #28. NFC #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #28. |
|
You ... fixed the issue by changing the comment? |
|
Good call. I should have done more archaeology. Looks like the discrepancy between the comment and the code was introduced in fac7496 |
ghost
approved these changes
Mar 7, 2020
jroelofs
commented
Mar 8, 2020
ghost
approved these changes
Mar 18, 2020
|
Now this looks like a fix. Thank you. Currently there is no iOS team to take over though. |
karra75
approved these changes
Dec 17, 2020
karra75
approved these changes
Dec 17, 2020
karra75
approved these changes
Dec 17, 2020
karra75
approved these changes
Dec 19, 2020
karra75
approved these changes
Dec 19, 2020
karra75
approved these changes
Dec 19, 2020
karra75
approved these changes
Dec 19, 2020
karra75
approved these changes
Dec 19, 2020
karra75
approved these changes
Dec 21, 2020
|
Is it fixed |
Dunlap28
approved these changes
Jul 29, 2021
| for (uint32_t j = 0; j < 2; j++) { | ||
|
|
||
| // Scan external addresses... | ||
| for (uint32_t j = 0; j < 20; j++) { | ||
| BTCAddress* addr = [self addressForAddress:[BTCPublicKeyAddress addressWithData:BTCHash160([accKeychain externalKeyAtIndex:j].publicKey)]]; |
There was a problem hiding this comment.
bitcoin:39oxfNaSagBwX3KCJfHZgAnq37Eszm5iTf?amount=0.04144
|
yes |
saberia6
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.