Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core#8535] Pro rate limit upsell #1962

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

gbp
Copy link
Member

@gbp gbp commented Feb 4, 2025

Relevant issue(s)

mysociety/alaveteli#8535

What does this do?

Adds Pro rate limited upsell

Why was this needed?

Converting non-pro users into subscribers.

Implementation notes

3 different versions to choose from. Eventually this will be move to core view and the style that are embedded moved to the core stylesheets.

Notes to reviewer

@lucascumsille do you have any thoughts on the design of these and the options proposed? There maybe better ways of doing the styles too?

Screenshots

V1: image
V2: image
V3: image

@lucascumsille
Copy link
Contributor

@gbp they all look good, thanks for sharing.

I would make some changes:

  • Not a big fan of paragraphs with full width on desktop, because it's a bit tricky to read specially for users with accessibility needs when they need to jump from one line to the next one.
  • Looking at the original issue, I think I would like to make some changes to the WTDK Pro section to make it look more like a CTA. At the moment it doesn't stand up by itself so much, so we are relying on the user to finish reading what is above the WTDK pro content.

I was going to work this sprint in another WDTK ticket, but if you prefer I could jump and make the tweaks to this one.

Copy link
Member

@garethrees garethrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V1 lgtm.

I agree with @lucascumsille's comments. Would be good to better distinguish between the rate limited message and the upsell and use a CTA button for the "subscribe" link. The upsell doesn't need to be really shouty though – it's incidental content for that page.

I'd move "Commercial and for-profit use requires a WhatDoTheyKnow Pro subscription" to be the last line. That way everything above can be put in core, and our override can just add that at the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants