Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counts files to db migration #295

Merged
merged 40 commits into from
Feb 27, 2024
Merged

Conversation

wooferclaw
Copy link
Collaborator

not yet tested

@wooferclaw wooferclaw changed the title Issue 221 counts db migration Counts files to db migration Feb 5, 2024
@jimmymathews
Copy link
Collaborator

I have moved the lines, that actually invoke caching, to the end of the tabular import workflow (main.nf). Now the ondemand containers (start.py) should rarely have to actually do the caching on their own. They still check to see if the cache is present, and recreate it if not, but in normal circumstances this should happen before the service containers are created.

@jimmymathews
Copy link
Collaborator

All tests pass for me.

@jimmymathews
Copy link
Collaborator

jimmymathews commented Feb 27, 2024

After this is merged we will need to update spt-dashboard to stop using mounted volumes. We should also do a fresh dataset import using the new functionality.

@jimmymathews
Copy link
Collaborator

Addresses #221 .

@jimmymathews jimmymathews merged commit a65f533 into main Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants