Make GNN plots available as an SPT CLI command and API endpoint #320
Conversation
|
Although I wanted to change the database query to be direct instead of through the API server, for expediency's sake + don't-fix-what-ain't-broke, I'll stick with the API server counts implementation and commit a thinner version of DataAccessor for now. |
|
|
|
This work entails updating the documentation in spt-data: Also, I suppose, committing the plot specification artifacts to spt-data for now. Similar to findings. |
|
All tests pass except for workflow tests, which complain about |
|
I would check that the new system of data-preloaded-images is getting used (in a recent update I moved these images to docker hub, so development doesn't require building them locally). |
We will have to check usage, probably the idea was that the test and build scripts would not need to reach into each other's directory contents. |
|
If the data loaded images live remotely, and I've modified one of the data loaded images to have two importance score studies so the plotting has something to compare, would that cause an issue? |
|
Yes, this is the scenario where, when this PR is complete, we would update the docker hub images. |
| spt graphs upload-importances --config_path=build/build_scripts/.graph_transformer.config --importances_csv_path=test/test_data/gnn_importances/1.csv | ||
|
|
||
| spt db upload-sync-findings --database-config-file=build/db/.spt_db.config.local test/test_data/findings.json | ||
| spt db upload-sync-small --database-config-file=build/db/.spt_db.config.local findings test/test_data/findings.json | ||
| spt db upload-sync-small --database-config-file=build/db/.spt_db.config.local gnn_plot_configurations test/test_data/gnn_plot.json |
There was a problem hiding this comment.
Both old and new versions of this build script reach into the test directory for data.
|
Tests passed. |
To close #319.