Remove Strongback support (#385)

- Removes Strongback modules - Removes unused dependencies - Updates documentation to indicate that Strongbacks are retired Resolves #384 {minor} Signed-off-by: Esta Nagy <[email protected]>
nagyesta · Jun 25, 2023 · 23ca0cf · 23ca0cf
1 parent 2f7a7fe
commit 23ca0cf
Show file tree

Hide file tree

Showing 87 changed files with 3 additions and 5,898 deletions.
diff --git a/.github/workflows/gradle-ci.yml b/.github/workflows/gradle-ci.yml
@@ -85,7 +85,6 @@ jobs:
             mission-control/build/reports/tests/test
             boosters/**/build/reports/tests/test
             mission-report/**/build/reports/tests/test
-            strongback/**/build/reports/tests/test
           retention-days: 5
       - name: Upload coverage to Codecov - Core
         uses: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # v3.1.4
@@ -136,24 +135,3 @@ jobs:
           token: ${{ secrets.CODECOV_TOKEN }}
           files: ./mission-report/flight-evaluation-report/build/reports/jacoco/report.xml,./mission-report/flight-evaluation-report/node/build/coverage/cobertura-coverage.xml
           flags: flighteval
-      - name: Upload coverage to Codecov - Strongback - Base
-        uses: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # v3.1.4
-        if: ${{ matrix.os == 'ubuntu-latest' }}
-        with:
-          token: ${{ secrets.CODECOV_TOKEN }}
-          file: ./strongback/strongback-base/build/reports/jacoco/report.xml
-          flags: strongback
-      - name: Upload coverage to Codecov - Strongback - H2 Supplier
-        uses: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # v3.1.4
-        if: ${{ matrix.os == 'ubuntu-latest' }}
-        with:
-          token: ${{ secrets.CODECOV_TOKEN }}
-          file: ./strongback/strongback-h2-supplier/build/reports/jacoco/report.xml
-          flags: h2
-      - name: Upload coverage to Codecov - Strongback - RMI Supplier
-        uses: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # v3.1.4
-        if: ${{ matrix.os == 'ubuntu-latest' }}
-        with:
-          token: ${{ secrets.CODECOV_TOKEN }}
-          file: ./strongback/strongback-rmi-supplier/build/reports/jacoco/report.xml
-          flags: rmi
diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml
@@ -118,21 +118,3 @@ jobs:
           token: ${{ secrets.CODECOV_TOKEN }}
           files: ./mission-report/flight-evaluation-report/build/reports/jacoco/report.xml,./mission-report/flight-evaluation-report/node/build/coverage/cobertura-coverage.xml
           flags: flighteval
-      - name: Upload coverage to Codecov - Strongback - Base
-        uses: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # v3.1.4
-        with:
-          token: ${{ secrets.CODECOV_TOKEN }}
-          file: ./strongback/strongback-base/build/reports/jacoco/report.xml
-          flags: strongback
-      - name: Upload coverage to Codecov - Strongback - H2 Supplier
-        uses: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # v3.1.4
-        with:
-          token: ${{ secrets.CODECOV_TOKEN }}
-          file: ./strongback/strongback-h2-supplier/build/reports/jacoco/report.xml
-          flags: h2
-      - name: Upload coverage to Codecov - Strongback - RMI Supplier
-        uses: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # v3.1.4
-        with:
-          token: ${{ secrets.CODECOV_TOKEN }}
-          file: ./strongback/strongback-rmi-supplier/build/reports/jacoco/report.xml
-          flags: rmi
diff --git a/README.md b/README.md
@@ -54,10 +54,8 @@ will at least take a look.
   - [Booster Test Kit](boosters/testkit)
 - Mission Report
     - [Flight Evaluation Report](mission-report/flight-evaluation-report)
-- Strongback
-    - [Strongback Base](strongback/strongback-base)
-    - [Strongback H2 Supplier](strongback/strongback-h2-supplier)
-    - [Strongback RMI Supplier](strongback/strongback-rmi-supplier)
+- Strongback (All modules removed in 4.1.x)
+    - Strongback functionality is completely removed in 4.1.x release as Strongbacks were very slow and hard to maintain.
 
 ## Terminology and Lifecycle
 

diff --git a/build.gradle b/build.gradle
@@ -53,7 +53,7 @@ versioner {
 }
 
 configure(subprojects.findAll({
-    !'boosters'.equalsIgnoreCase(it.name) && !'strongback'.equalsIgnoreCase(it.name) && !'mission-report'.equalsIgnoreCase(it.name)
+    !'boosters'.equalsIgnoreCase(it.name) && !'mission-report'.equalsIgnoreCase(it.name)
 })) {
     apply plugin: 'java'
     apply plugin: 'checkstyle'

diff --git a/codecov.yml b/codecov.yml
@@ -19,12 +19,6 @@ coverage:
         flags: testkit
       flighteval:
         flags: flighteval
-      strongback:
-        flags: strongback
-      h2:
-        flags: h2
-      rmi:
-        flags: rmi
     patch: false
 flags:
   core:
@@ -48,12 +42,3 @@ flags:
   flighteval:
     paths:
       - ./mission-report/flight-evaluation-report
-  strongback:
-    paths:
-      - ./strongback/strongback-base
-  h2:
-    paths:
-      - ./strongback/strongback-h2-supplier
-  rmi:
-    paths:
-      - ./strongback/strongback-rmi-supplier
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -10,8 +10,6 @@ logbackReport = "1.4.8"
 jackson = "2.15.2"
 gson = "2.10.1"
 slf4j = "1.7.36"
-h2 = "2.1.214"
-jdbi3 = "3.39.1"
 
 lombok = "1.18.28"
 findbugs = "3.0.2"
@@ -55,9 +53,6 @@ jackson-databind = { module = "com.fasterxml.jackson.core:jackson-databind", ver
 
 slf4j-api = { module = "org.slf4j:slf4j-api", version.ref = "slf4j" }
 
-h2 = { module = "com.h2database:h2", version.ref = "h2" }
-jdbi3-sqlobject = { module = "org.jdbi:jdbi3-sqlobject", version.ref = "jdbi3" }
-
 lombok = { module = "org.projectlombok:lombok", version.ref = "lombok" }
 findbugs-jsr305 = { module = "com.google.code.findbugs:jsr305", version.ref = "findbugs" }
 

diff --git a/gradle/verification-metadata.xml b/gradle/verification-metadata.xml
@@ -136,11 +136,6 @@
             <sha256 value="811ffa1b239956fd512537eebd8810d55ca8948115eaeb6bed1374395b161182" origin="Generated by Gradle"/>
          </artifact>
       </component>
-      <component group="com.fasterxml.jackson" name="jackson-bom" version="2.10.5.20201202">
-         <artifact name="jackson-bom-2.10.5.20201202.pom">
-            <sha256 value="7e7607bbea110389bffb243abca9081711049c0d5bc6d6fc5a47e59b2896f66b" origin="Generated by Gradle"/>
-         </artifact>
-      </component>
       <component group="com.fasterxml.jackson" name="jackson-bom" version="2.13.3">
          <artifact name="jackson-bom-2.13.3.pom">
             <sha256 value="df675b83b6caba7602fb47d75d4bb513c2af4c0a6155d7e397c0ec0f34112c75" origin="Generated by Gradle"/>
@@ -171,11 +166,6 @@
             <sha256 value="1ead630255c488c51b5e0ab560c76c2371ad26ae36dadf0929c526572ea5b38b" origin="Generated by Gradle"/>
          </artifact>
       </component>
-      <component group="com.fasterxml.jackson" name="jackson-parent" version="2.10">
-         <artifact name="jackson-parent-2.10.pom">
-            <sha256 value="a50db80829c4f897c6d0e7e95472cbb43b0ebece135a68e39c27b8a6fe33e481" origin="Generated by Gradle"/>
-         </artifact>
-      </component>
       <component group="com.fasterxml.jackson" name="jackson-parent" version="2.13">
          <artifact name="jackson-parent-2.13.pom">
             <sha256 value="2bba89978172af1effcb4d143d09921a3f3082ca4dcf122b1ded98bf55b2ad57" origin="Generated by Gradle"/>
@@ -871,14 +861,6 @@
             <sha256 value="7042cfdca52bdbf20b1649b9a5175fd466d2872073bb8446fc2f8779948695f8" origin="Generated by Gradle"/>
          </artifact>
       </component>
-      <component group="io.leangen.geantyref" name="geantyref" version="1.3.14">
-         <artifact name="geantyref-1.3.14.jar">
-            <sha256 value="62b722d132454503904a5f7b0a47a24f0fc581821ec8d3687df1e0f146c6d61e" origin="Generated by Gradle"/>
-         </artifact>
-         <artifact name="geantyref-1.3.14.pom">
-            <sha256 value="0cda1903cb9e2c1d4b0372a8f0e0605c980a761b4cbc11e8d804e4fac78052ee" origin="Generated by Gradle"/>
-         </artifact>
-      </component>
       <component group="io.projectreactor" name="reactor-bom" version="2022.0.0">
          <artifact name="reactor-bom-2022.0.0.pom">
             <sha256 value="609a39db5fad24765f6c16f878f05664e14483b846eaa4174664246e5986a5eb" origin="Generated by Gradle"/>
@@ -1509,21 +1491,6 @@
             <sha256 value="467f935f271473d9e9919cb7decf3874c948d16339a3e2e2ed980628f72cf573" origin="Generated by Gradle"/>
          </artifact>
       </component>
-      <component group="org.basepom" name="basepom-foundation" version="54">
-         <artifact name="basepom-foundation-54.pom">
-            <sha256 value="05e8dfcd69841c62fc88905071f445eabeee123dca34791461f3669f5f480e62" origin="Generated by Gradle"/>
-         </artifact>
-      </component>
-      <component group="org.basepom" name="basepom-minimal" version="54">
-         <artifact name="basepom-minimal-54.pom">
-            <sha256 value="c193a9123375e173f69add40f3f619351fc88a6da7508ab8af233b42dc2cd3a2" origin="Generated by Gradle"/>
-         </artifact>
-      </component>
-      <component group="org.basepom" name="basepom-oss" version="54">
-         <artifact name="basepom-oss-54.pom">
-            <sha256 value="5f34b518a4b5f61fbce3c926b6cc8804b82b0636175b905407553cc7d73c53f5" origin="Generated by Gradle"/>
-         </artifact>
-      </component>
       <component group="org.bouncycastle" name="bcpg-jdk18on" version="1.71">
          <artifact name="bcpg-jdk18on-1.71.jar">
             <sha256 value="57f9ab76a8358abbea90ba1ef8e553b8ae3d07b2337078a4ca20b1cbd48b4ec5" origin="Generated by Gradle"/>
@@ -1718,42 +1685,6 @@
             <sha256 value="fb443d90db19ec25e7055412f980efdbc086f2d8170e2fe2a876f6e43b9bdc97" origin="Generated by Gradle"/>
          </artifact>
       </component>
-      <component group="org.jdbi" name="jdbi3-bom" version="3.39.1">
-         <artifact name="jdbi3-bom-3.39.1.pom">
-            <sha256 value="abd633160d0f35d2b02a222760a08651e546500688f7e670ae82ee4bc40e044b" origin="Generated by Gradle"/>
-         </artifact>
-      </component>
-      <component group="org.jdbi" name="jdbi3-build-parent" version="3.39.1">
-         <artifact name="jdbi3-build-parent-3.39.1.pom">
-            <sha256 value="773fdcc25d6d42ca9a98740f8467b2f6997b13990f2e2bccf76f60c0f05a1057" origin="Generated by Gradle"/>
-         </artifact>
-      </component>
-      <component group="org.jdbi" name="jdbi3-core" version="3.39.1">
-         <artifact name="jdbi3-core-3.39.1.jar">
-            <sha256 value="97df5ff14aab838af473dc20af507506f7035add9046ab9984702d7b118b4cbb" origin="Generated by Gradle"/>
-         </artifact>
-         <artifact name="jdbi3-core-3.39.1.pom">
-            <sha256 value="f25d6ff10f0a4592483a7e0dc9144c35660d747affe1fc3531743c6a4d94f17e" origin="Generated by Gradle"/>
-         </artifact>
-      </component>
-      <component group="org.jdbi" name="jdbi3-sqlobject" version="3.39.1">
-         <artifact name="jdbi3-sqlobject-3.39.1.jar">
-            <sha256 value="978b43de72ff2a4adb8a832e57c0f3fe752c1487df348610e902b9afde11ddf3" origin="Generated by Gradle"/>
-         </artifact>
-         <artifact name="jdbi3-sqlobject-3.39.1.pom">
-            <sha256 value="b7cff711fc8963966a926f26d951592b79100cf7ee80412c028e6eb20ed352f8" origin="Generated by Gradle"/>
-         </artifact>
-      </component>
-      <component group="org.jdbi.internal" name="jdbi3-parent" version="3.39.1">
-         <artifact name="jdbi3-parent-3.39.1.pom">
-            <sha256 value="dc3d3d10a2eff10191e3018255b6a00a55809339463734c78e45e6a1106032e2" origin="Generated by Gradle"/>
-         </artifact>
-      </component>
-      <component group="org.jdbi.internal" name="jdbi3-root" version="3.39.1">
-         <artifact name="jdbi3-root-3.39.1.pom">
-            <sha256 value="cbc284c8925c74ab5d80e3188d80f4c03d06a9720eed965c067ac49e9fbf083b" origin="Generated by Gradle"/>
-         </artifact>
-      </component>
       <component group="org.jsoup" name="jsoup" version="1.16.1">
          <artifact name="jsoup-1.16.1.jar">
             <sha256 value="1f115726540ddf71958c14bc517ebfc49cf481e91cd917b0face84f01272e901" origin="Generated by Gradle"/>
@@ -2382,11 +2313,6 @@
             <sha256 value="7ea60b1cd2774e50ca85faffa37fc747d3bac04e04602b15e4c641281fae8235" origin="Generated by Gradle"/>
          </artifact>
       </component>
-      <component group="org.testcontainers" name="testcontainers-bom" version="1.18.0">
-         <artifact name="testcontainers-bom-1.18.0.pom">
-            <sha256 value="cd00040b49a80ac561006abcbaefede566907af50272cb7de56511d2731692f9" origin="Generated by Gradle"/>
-         </artifact>
-      </component>
       <component group="org.testng" name="testng" version="7.8.0">
          <artifact name="testng-7.8.0.jar">
             <sha256 value="dbbc43e2c64623661c3537f9d74061eb6c8fc3e5b4376f31fadb16de2b200f88" origin="Generated by Gradle"/>

diff --git a/settings.gradle b/settings.gradle
@@ -6,6 +6,3 @@ include 'boosters:booster-testng'
 include 'boosters:booster-junit4'
 include 'boosters:booster-cucumber-jvm'
 include 'mission-report:flight-evaluation-report'
-include 'strongback:strongback-base'
-include 'strongback:strongback-h2-supplier'
-include 'strongback:strongback-rmi-supplier'
diff --git a/strongback/strongback-base/README.md b/strongback/strongback-base/README.md