Check return code when starting ncdns service #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyRand
force-pushed
the
service-return-code
branch
3 times, most recently
from
aa57b4e to
77b989b
Compare
|
Works fine on Windows 7, successfully catches the error on Windows Server Core 2019. Holding off on merging this until the error is fixed, so that we don't break CI. |
JeremyRand
force-pushed
the
service-return-code
branch
from
77b989b to
62c2fd3
Compare
JeremyRand
force-pushed
the
service-return-code
branch
from
1ba0185 to
b95242c
Compare
|
Now that we've bumped ncdns to v0.1.1, which has the service/PIE fix included, this PR no longer breaks CI. Time to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #71