Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 1 NuGet dependencies #98

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Update 1 NuGet dependencies #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Tests/Client/TestClient.nfproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
<Reference Include="nanoFramework.Runtime.Events, Version=1.11.18.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\..\packages\nanoFramework.Runtime.Events.1.11.18\lib\nanoFramework.Runtime.Events.dll</HintPath>
</Reference>
<Reference Include="nanoFramework.Runtime.Native, Version=1.6.12.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\..\packages\nanoFramework.Runtime.Native.1.6.12\lib\nanoFramework.Runtime.Native.dll</HintPath>
<Reference Include="nanoFramework.Runtime.Native, Version=1.7.1.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\..\packages\nanoFramework.Runtime.Native.1.7.1\lib\nanoFramework.Runtime.Native.dll</HintPath>
</Reference>
<Reference Include="nanoFramework.System.Text, Version=1.2.54.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\..\packages\nanoFramework.System.Text.1.2.54\lib\nanoFramework.System.Text.dll</HintPath>
Expand Down
2 changes: 1 addition & 1 deletion Tests/Client/packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
<packages>
<package id="nanoFramework.CoreLibrary" version="1.15.5" targetFramework="netnano1.0" />
<package id="nanoFramework.Runtime.Events" version="1.11.18" targetFramework="netnano1.0" />
<package id="nanoFramework.Runtime.Native" version="1.6.12" targetFramework="netnano1.0" />
<package id="nanoFramework.Runtime.Native" version="1.7.1" targetFramework="netnano1.0" />
<package id="nanoFramework.System.Text" version="1.2.54" targetFramework="netnano1.0" />
</packages>
6 changes: 3 additions & 3 deletions Tests/Client/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
},
"nanoFramework.Runtime.Native": {
"type": "Direct",
"requested": "[1.6.12, 1.6.12]",
"resolved": "1.6.12",
"contentHash": "RlJ882CK7D2HkkGHDw1a2xgiEM+1+Nd6iTA+OmzF5QIxbv0SX9qBesueIWsc6RsiQGqBEeBXh4zZ2+TBGL62VQ=="
"requested": "[1.7.1, 1.7.1]",
"resolved": "1.7.1",
"contentHash": "RCiG3D+SxG4wVSBXuXP0y8EZWBd65bfJ9AJj0USNnfL65Aa+nUXmXa6QIxkeolSjDH4jLgKjlIuTXOA7t+AQGQ=="
Comment on lines +19 to +21
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Inconsistent version of nanoFramework.Runtime.Native across packages.lock.json files

The package nanoFramework.Runtime.Native has been updated to version 1.7.1 in Tests/Client/packages.lock.json but is not specified in nanoFramework.Device.Bluetooth/packages.lock.json. This inconsistency may lead to version conflicts or unexpected behaviors.

Recommendations:

  • Update nanoFramework.Device.Bluetooth/packages.lock.json to specify nanoFramework.Runtime.Native version 1.7.1 to ensure consistency across the project.
🔗 Analysis chain

LGTM. Verify compatibility with the updated package.

The update of nanoFramework.Runtime.Native from version 1.6.12 to 1.7.1 has been correctly implemented in the packages.lock.json file. The requested version, resolved version, and content hash have all been updated appropriately.

To ensure this update doesn't introduce any breaking changes or compatibility issues, please verify:

  1. The changelog or release notes for nanoFramework.Runtime.Native version 1.7.1.
  2. Any dependencies of this package that might be affected.
  3. The project's compatibility with this new version through thorough testing.

Run the following script to check for any direct usage of nanoFramework.Runtime.Native in the project:

This will help identify any code that might need review due to the version update.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for usage of nanoFramework.Runtime.Native in the project

# Test: Look for imports or usages of nanoFramework.Runtime.Native
rg --type csharp "using.*nanoFramework\.Runtime\.Native" -g '!obj/**'

Length of output: 230

Script:

#!/bin/bash
# Description: Check the version of nanoFramework.Runtime.Native in nanoFramework.Device.Bluetooth/packages.lock.json

jq -r '.dependencies."nanoFramework.Runtime.Native".version' nanoFramework.Device.Bluetooth/packages.lock.json

Length of output: 117

},
"nanoFramework.System.Text": {
"type": "Direct",
Expand Down
2 changes: 1 addition & 1 deletion nanoFramework.Device.Bluetooth.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ This package requires a target with nanoFramework.Device.Bluetooth v$nativeVersi
<tags>nanoFramework C# csharp netmf netnf nanoFramework.Device.Bluetooth</tags>
<dependencies>
<dependency id="nanoFramework.CoreLibrary" version="1.15.5" />
<dependency id="nanoFramework.Runtime.Native" version="1.6.12" />
<dependency id="nanoFramework.Runtime.Native" version="1.7.1" />
<dependency id="nanoFramework.Runtime.Events" version="1.11.18" />
<dependency id="nanoFramework.System.Text" version="1.2.54" />
<dependency id="nanoFramework.System.Collections" version="1.5.45" />
Expand Down
4 changes: 2 additions & 2 deletions nanoFramework.Device.Bluetooth/nanoFramework.Device.Bluetooth.nfproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,8 @@
<Reference Include="nanoFramework.Runtime.Events, Version=1.11.18.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.Runtime.Events.1.11.18\lib\nanoFramework.Runtime.Events.dll</HintPath>
</Reference>
<Reference Include="nanoFramework.Runtime.Native, Version=1.6.12.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.Runtime.Native.1.6.12\lib\nanoFramework.Runtime.Native.dll</HintPath>
<Reference Include="nanoFramework.Runtime.Native, Version=1.7.1.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.Runtime.Native.1.7.1\lib\nanoFramework.Runtime.Native.dll</HintPath>
</Reference>
<Reference Include="nanoFramework.System.Collections, Version=1.5.45.0, Culture=neutral, PublicKeyToken=c07d481e9758c731">
<HintPath>..\packages\nanoFramework.System.Collections.1.5.45\lib\nanoFramework.System.Collections.dll</HintPath>
Expand Down
2 changes: 1 addition & 1 deletion nanoFramework.Device.Bluetooth/packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<packages>
<package id="nanoFramework.CoreLibrary" version="1.15.5" targetFramework="netnano1.0" />
<package id="nanoFramework.Runtime.Events" version="1.11.18" targetFramework="netnano1.0" />
<package id="nanoFramework.Runtime.Native" version="1.6.12" targetFramework="netnano1.0" />
<package id="nanoFramework.Runtime.Native" version="1.7.1" targetFramework="netnano1.0" />
<package id="nanoFramework.System.Collections" version="1.5.45" targetFramework="netnano1.0" />
<package id="nanoFramework.System.Text" version="1.2.54" targetFramework="netnano1.0" />
<package id="Nerdbank.GitVersioning" version="3.6.143" developmentDependency="true" targetFramework="netnano1.0" />
Expand Down
6 changes: 3 additions & 3 deletions nanoFramework.Device.Bluetooth/packages.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
},
"nanoFramework.Runtime.Native": {
"type": "Direct",
"requested": "[1.6.12, 1.6.12]",
"resolved": "1.6.12",
"contentHash": "RlJ882CK7D2HkkGHDw1a2xgiEM+1+Nd6iTA+OmzF5QIxbv0SX9qBesueIWsc6RsiQGqBEeBXh4zZ2+TBGL62VQ=="
"requested": "[1.7.1, 1.7.1]",
"resolved": "1.7.1",
"contentHash": "RCiG3D+SxG4wVSBXuXP0y8EZWBd65bfJ9AJj0USNnfL65Aa+nUXmXa6QIxkeolSjDH4jLgKjlIuTXOA7t+AQGQ=="
},
"nanoFramework.System.Collections": {
"type": "Direct",
Expand Down
Loading