-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Midi port selection based on selected controller #79
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 96.31% 96.37% +0.06%
==========================================
Files 15 15
Lines 1058 1077 +19
==========================================
+ Hits 1019 1038 +19
Misses 39 39 ☔ View full report in Codecov by Sentry. |
336b6ff
to
8e7e6e4
Compare
49bc4a9
to
404060e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix pre-commit.
Try clicking 'Start handling' when at least one port is not selected ((none)
). An exception is raised because there is None
as a value in the dict. And pydantic
model expects only str
. It should be fixed.
added port selection
a8cb9fb
to
813be66
Compare
No description provided.