Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midi port selection based on selected controller #79

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

modyf01
Copy link
Contributor

@modyf01 modyf01 commented May 8, 2024

No description provided.

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.37%. Comparing base (6b7f955) to head (a8cb9fb).

Current head a8cb9fb differs from pull request most recent head 813be66

Please upload reports for the commit 813be66 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   96.31%   96.37%   +0.06%     
==========================================
  Files          15       15              
  Lines        1058     1077      +19     
==========================================
+ Hits         1019     1038      +19     
  Misses         39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

midi_app_controller/gui/midi_status.py Outdated Show resolved Hide resolved
midi_app_controller/state/state_manager.py Outdated Show resolved Hide resolved
midi_app_controller/models/app_state.py Outdated Show resolved Hide resolved
@modyf01 modyf01 requested a review from lukaszsmolinski May 15, 2024 14:18
@modyf01 modyf01 force-pushed the midi_port_selection branch 2 times, most recently from 336b6ff to 8e7e6e4 Compare June 2, 2024 17:31
midi_app_controller/state/state_manager.py Outdated Show resolved Hide resolved
midi_app_controller/models/app_state.py Show resolved Hide resolved
midi_app_controller/state/state_manager.py Outdated Show resolved Hide resolved
midi_app_controller/state/state_manager.py Outdated Show resolved Hide resolved
midi_app_controller/state/state_manager.py Outdated Show resolved Hide resolved
@modyf01 modyf01 force-pushed the midi_port_selection branch 3 times, most recently from 49bc4a9 to 404060e Compare June 7, 2024 19:30
@modyf01 modyf01 requested a review from lukaszsmolinski June 8, 2024 09:13
@modyf01 modyf01 requested a review from lukaszsmolinski June 12, 2024 12:50
Copy link
Contributor

@lukaszsmolinski lukaszsmolinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix pre-commit.

Try clicking 'Start handling' when at least one port is not selected ((none)). An exception is raised because there is None as a value in the dict. And pydantic model expects only str. It should be fixed.

@modyf01 modyf01 force-pushed the midi_port_selection branch from a8cb9fb to 813be66 Compare June 13, 2024 07:42
@modyf01 modyf01 merged commit aafdf25 into main Jun 13, 2024
9 checks passed
@lukaszsmolinski lukaszsmolinski deleted the midi_port_selection branch June 13, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants