Minor prompt improvements #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change display_name and module_name from type placeholder to default Change include_reader_plugin, include_writer_plugin, include_sample_data_plugin and include_widget_plugin from default value 'true' to default value 'false'.
Add comment about the new-plugin-name argument to copier
|
I believe our changes to the default values borked some tests. Will look into the correct fix 😊 |
|
@pearsomark let me know if you need help fixing the tests (replacing the |
|
Thanks for the pointer to the tests. I will look at it in the next few days
and let you know if I need help.
Mark
…On Tue, 26 Nov 2024 at 16:30, Draga Doncila Pop ***@***.***> wrote:
@pearsomark <https://github.com/pearsomark> let me know if you need help
fixing the tests (replacing the n parameterized plugin types in this test
<https://github.com/napari/napari-plugin-template/blob/main/tests/test_create_template.py#L101-L102>
with ys for the other plugin types), or would like me to take over here.
Otherwise I'll wait for your updates 😊!
—
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABOMTKMDUB5H4JZEKP2DNWL2CQBP5AVCNFSM6AAAAABSND2TLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJZGY4TKMRUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a comment in the readme about the copier destination directory argument.
Update copier.yaml to change some prompts to defaults and change some includes from true to false.