Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of manifest reference table. #326

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Fix rendering of manifest reference table. #326

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4041496
Fix rendering of manifest reference table.
melissawm Nov 21, 2023
f3b3976
Merge branch 'main' into fix-manifest
nclack Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/npe2/manifest/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,20 +128,19 @@ class Config:
icon: str = Field(
"",
description="The path to a square PNG icon of at least 128x128 pixels (256x256 "
"for Retina screens). May be one of:\n"
" - a secure (https) URL\n"
" - a path relative to the manifest file, (must be shipped in the sdist)\n"
" - a string in the format `{package}:{resource}`, where `package` and "
"for Retina screens). May be one of: "
"<ul><li>a secure (https) URL </li>"
"<li>a path relative to the manifest file, (must be shipped in the sdist)</li>"
"<li>a string in the format `{package}:{resource}`, where `package` and "
"`resource` are arguments to `importlib.resources.path(package, resource)`, "
"(e.g. `top_module.some_folder:my_logo.png`).",
"(e.g. `top_module.some_folder:my_logo.png`).</li></ul>",
)
_validate_icon_path = validator("icon", allow_reuse=True)(_validators.icon_path)

categories: List[Category] = Field(
default_factory=list,
description="A list of categories that this plugin belongs to. This is used to "
"help users discover your plugin. Allowed values:\n"
f"`[{', '.join(Category)}]`",
f"help users discover your plugin. Allowed values: `[{', '.join(Category)}]`",
)
# Plugins rely on certain guarantees to interoperate propertly with the
# plugin engine. These include the manifest specification, conventions
Expand Down