Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Add cross references to widget contributions #331

Merged
merged 6 commits into from
Apr 5, 2024

Conversation

lucyleeow
Copy link
Contributor

@lucyleeow lucyleeow commented Dec 7, 2023

Depends on napari/docs#286

Adds references to new 'creating widgets' section and gallery and cookiecutter to widget contributions page.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (595b088) to head (9f2e25f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #331   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         2750      2750           
=========================================
  Hits          2750      2750           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psobolewskiPhD
Copy link
Member

You can edit OP with
Depends on
To make the CI action check it.

@lucyleeow
Copy link
Contributor Author

Did it work ?

@psobolewskiPhD
Copy link
Member

psobolewskiPhD commented Dec 7, 2023

Ha! I got my repos confused. This one doesn't have the action to check for dependency between PR.
Could be worth adding though since things in this repo might depend on things being merged in napari/napari or napari/docs in this case.

@lucyleeow
Copy link
Contributor Author

@psobolewskiPhD I think this is ready for review now that the dependency has been merged 🙏 Thank you!

Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @lucyleeow

@DragaDoncila DragaDoncila merged commit 636969a into napari:main Apr 5, 2024
32 checks passed
@lucyleeow lucyleeow deleted the doc_widget branch April 5, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants