Fix test_all_plugins workflow
#370
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
January 15, 2025 18:03
|
CI here will continue failing until we merge #371 (at least 😆) |
DragaDoncila
changed the title
test_all_plugins workflow
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 37
Lines 2709 2709
=========================================
Hits 2709 2709 ☔ View full report in Codecov by Sentry. |
| python-version: 3.9 | ||
| miniforge-variant: Mambaforge | ||
| python-version: '3.10' | ||
| miniforge-variant: Miniforge3 |
There was a problem hiding this comment.
Suggested change
| miniforge-variant: Miniforge3 | |
| miniforge-variant: Miniforge3 | |
| conda-remove-defaults: "true" |
To silence the warning
https://github.com/napari/npe2/actions/runs/12840078624
psobolewskiPhD
approved these changes
Jan 18, 2025
There was a problem hiding this comment.
Looks good!
https://github.com/napari/npe2/actions/runs/12840078624
Any thought to making it more than 10?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ages ago, the
test_all_plugins.ymlworkflow was no longer usable because the GHA matrix allows for a maximum of 256 jobs, and we have far more plugins than that.This PR updates the workflow to:
$GITHUB_OUTPUTenvironment file to set the matrix strategy output instead of::set-outputcommand which is soon to be deprecatedminiforge3instead ofmambaforgefor setting up conda because a warning in an action said soNote the workflow is still triggered in the same ways: via manual dispatch, or via the
test-all-pluginslabel added to a PR