Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase OpenID Connect timeouts for Kafka client #2754

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

lpsinger
Copy link
Member

@lpsinger lpsinger commented Dec 6, 2024

The authentication was timing out, leading to the Lambda invocations failing and being retried, which caused duplicate distributions of GCN Circulars.

See #2659.

The authentication was timing out, leading to the Lambda
invocations failing and being retried, which caused duplicate
distributions of GCN Circulars.

See nasa-gcn#2659.
@lpsinger lpsinger requested review from Courey and dakota002 December 6, 2024 14:42
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 6.22%. Comparing base (7409caf) to head (6ecf79e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
app/lib/kafka.server.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #2754      +/-   ##
========================================
- Coverage   6.23%   6.22%   -0.01%     
========================================
  Files        167     167              
  Lines       4253    4258       +5     
  Branches     472     472              
========================================
  Hits         265     265              
- Misses      3986    3991       +5     
  Partials       2       2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpsinger lpsinger merged commit f4c5ac0 into nasa-gcn:main Dec 6, 2024
12 checks passed
@lpsinger lpsinger deleted the increase-oidc-timeout branch December 6, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants