Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallbacks for Deezer + user uploaded tracks #787

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

OhMyMndy
Copy link

@OhMyMndy OhMyMndy commented Jan 6, 2025

This fixes the following issues I had with some obscure scenarios:

  • I have uploaded mp3 files to Deezer, which are in playlists, I want to be able to back up those tracks as well as the ones from Deezer
  • I have songs in a playlist which have newer uploads of the same track, probably a better quality version. This means that the song ID in my playlist isn't downloadable anymore.

Changes:

  • Added option to use DEEZER_ACCESS_TOKEN environment variable to log in to Deezer API
  • Fallbacks for tracks which have newer versions of them, using the gw api, because the Rest API doesn't provide that in my use case.
  • Updated multidict to 6.1.0, because I couldn't compile the 6.0.4 version on Fedora 41 with Python 3.12.8
  • Updated requests to 2.32.3, it had a vulnerability in 2.23.0

Not sure if #700 is still necessary, because I tried that patch, and in this use case the "alternative" key wasn't filled for the track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant