Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ayr 389/create header component #69

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Ayr 389/create header component #69

merged 5 commits into from
Nov 27, 2023

Conversation

zaiziclebby
Copy link
Contributor

@zaiziclebby zaiziclebby commented Nov 21, 2023 •
edited
Loading

Changes in this PR

  • Created Header SCSS , linked to base.html
  • Added BEM styles to SCSS file
  • Added a sass mixin to header.scss file so media query code is not repeated and can be reused more efficiently.
  • Updated the phase banner content
  • Wrote a playwright test which checks the a user can head to the header URL for The National Archives successfully, click on the link and view the webpage.

JIRA ticket

https://national-archives.atlassian.net/browse/AYR-389

Screenshots of UI changes

Before

Screenshot 2023-11-24 at 14 53 15

After

Screenshot 2023-11-21 at 10 45 49
  • Requires env variable(s) to be updated

@zaiziclebby
Copy link
Contributor Author

Not ready for review

pgandhizaizi
pgandhizaizi approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@pgandhizaizi pgandhizaizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@zaiziclebby zaiziclebby merged commit 272483d into main Nov 27, 2023
6 checks passed
@anthonyhashemi anthonyhashemi deleted the AYR-389/Create-header-component branch January 4, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgandhizaizi pgandhizaizi pgandhizaizi approved these changes

@colinbowen colinbowen Awaiting requested review from colinbowen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaiziclebby @pgandhizaizi