Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullptr dereference in mesh_map::readMap() and remove dependency on mesh_client #73

Open
wants to merge 2 commits into
base: humble
Choose a base branch
from
Open

Fix nullptr dereference in mesh_map::readMap() and remove dependency on mesh_client #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee4b9fc
Fix segv in mesh_map when no mesh_buffer could be loaded
JustusBraun Jan 7, 2025
eb06721
Remove <exec_depend> key on removed package mesh_client
JustusBraun Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions mesh_map/src/mesh_map.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,10 +284,9 @@ bool MeshMap::readMap()
hdf5_mesh_input->setMeshName(mesh_working_part);
lvr2::MeshBufferPtr mesh_buffer = hdf5_mesh_input->MeshIO::load(mesh_working_part);

RCLCPP_DEBUG_STREAM(node->get_logger(), "Convert buffer to HEM: \n" << *mesh_buffer);

if(mesh_buffer)
{
RCLCPP_DEBUG_STREAM(node->get_logger(), "Convert buffer to HEM: \n" << *mesh_buffer);
RCLCPP_DEBUG_STREAM(node->get_logger(), "Creating mesh of type '" << hem_impl_ << "'");
mesh_ptr = createHemByName(hem_impl_, mesh_buffer);
RCLCPP_INFO_STREAM(node->get_logger(), "The mesh of type '" << hem_impl_ << "' has been loaded successfully with "
Expand Down
1 change: 0 additions & 1 deletion mesh_navigation/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

<exec_depend>mbf_mesh_core</exec_depend>
<exec_depend>mbf_mesh_nav</exec_depend>
<exec_depend>mesh_client</exec_depend>
<exec_depend>mesh_controller</exec_depend>
<exec_depend>mesh_layers</exec_depend>
<exec_depend>mesh_map</exec_depend>
Expand Down
Loading