FIX: Concurrency problem in locator allNodes.

naver · Jul 3, 2024 · b677f40 · b677f40
1 parent 715f73a
commit b677f40
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/main/java/net/spy/memcached/ArcusKetamaNodeLocator.java b/src/main/java/net/spy/memcached/ArcusKetamaNodeLocator.java
@@ -32,6 +32,7 @@
 import java.util.SortedSet;
 import java.util.TreeMap;
 import java.util.TreeSet;
+import java.util.concurrent.CopyOnWriteArrayList;
 import java.util.concurrent.locks.Lock;
 import java.util.concurrent.locks.ReentrantLock;
 
@@ -66,7 +67,7 @@ public ArcusKetamaNodeLocator(List<MemcachedNode> nodes) {
   public ArcusKetamaNodeLocator(List<MemcachedNode> nodes,
                                 ArcusKetamaNodeLocatorConfiguration conf) {
     super();
-    allNodes = nodes;
+    allNodes = new CopyOnWriteArrayList<>(nodes);
     ketamaNodes = new TreeMap<>();
     config = conf;
 

diff --git a/src/main/java/net/spy/memcached/ArcusReplKetamaNodeLocator.java b/src/main/java/net/spy/memcached/ArcusReplKetamaNodeLocator.java
@@ -32,6 +32,7 @@
 import java.util.SortedSet;
 import java.util.TreeMap;
 import java.util.TreeSet;
+import java.util.concurrent.CopyOnWriteArrayList;
 import java.util.concurrent.locks.Lock;
 import java.util.concurrent.locks.ReentrantLock;
 
@@ -65,7 +66,7 @@ public class ArcusReplKetamaNodeLocator extends SpyObject implements NodeLocator
 
   public ArcusReplKetamaNodeLocator(List<MemcachedNode> nodes) {
     super();
-    allNodes = nodes;
+    allNodes = new CopyOnWriteArrayList<>(nodes);
     ketamaGroups = new TreeMap<>();
     allGroups = new HashMap<>();