Fix negativeMin self-comparison to decimalMin in Jakarta/Javax validation #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
requested review from
acktsap,
benelog,
jwChung,
mhyeon-lee,
seongahjo and
SooKim1110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect self-comparison operation in JakartaValidationConstraintGenerator where negativeMin was being compared with itself instead of decimalMin.
Related issue: #1127
How Has This Been Tested?
Since Fixture Monkey implements two validation flows as mentioned in the issue discussion, we can be confident this fix won't affect existing behavior. While the second validation flow has been correctly handling the validation, this fix ensures the JakartaValidationConstraintGenerator (first flow) also works as intended.
Is the Document updated?
No documentation update is required as this is a bug fix for internal implementation.