Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav 183 make viewer app responsive #20

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

clukas1
Copy link
Member

@clukas1 clukas1 commented Sep 15, 2024

Hacky workarounds, but should do the job for this project.

@clukas1 clukas1 requested a review from munterfi September 15, 2024 11:24
@clukas1 clukas1 self-assigned this Sep 15, 2024
@clukas1 clukas1 added bug Something isn't working enhancement New feature or request dependencies Pull requests that update a dependency file labels Sep 15, 2024
@munterfi
Copy link
Member

Thanks @clukas1, nice work!

Unfortunately, sometimes the map doesn't display, such as when routing from Wädenswil to Gurten Kulm:

image

And the map:
image

Other routes work fine. Maybe it has something to do with connections that consist of many legs?

@munterfi
Copy link
Member

Another example:

image

@clukas1
Copy link
Member Author

clukas1 commented Sep 16, 2024

Thanks @clukas1, nice work!

Unfortunately, sometimes the map doesn't display, such as when routing from Wädenswil to Gurten Kulm:

Other routes work fine. Maybe it has something to do with connections that consist of many legs?

Thanks for finding this issue, this was due to a syntax error caused by my 6' Walk strings, which resulted in bindPopup('6' Walk'); --> syntax error.

fixed in 4279c84

@munterfi
Copy link
Member

Thanks @clukas1!

Now it works for most cases, but there are still some cases where the map fails to load:

  • Connection:
    image

  • Map:
    image

@clukas1
Copy link
Member Author

clukas1 commented Sep 16, 2024

@munterfi thanks for the comprehensive testing.

Looks like it was the same issue ' (single quotes) in text. This time french name Flon, pl. de l'Europe. I've now added an escape string method to hopefully prevent all cases now. (55e526c)

image

@munterfi
Copy link
Member

Thanks @clukas1, looks good to merge.

@munterfi munterfi merged commit e52f3e1 into main Sep 16, 2024
2 checks passed
@munterfi munterfi deleted the NAV-183-Make-viewer-app-responsive branch September 16, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants