merging into devel #117
Merged
merging into devel #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silencing teststhat for later package update.
#105 Issue fix
#107 Normalization error when only using a input matrix - split input.data into sc.data and enrichment.data
updating scale.factor for normalizatrion
added parallelization to normalize function. This might be memory intensive, but still would offer a speed benefit over a strictly single threaded approach. Under the hood, bpvec splits the vector into the number of workers and then executes the function on them, before joining it back together. I tested it against the equivalent single thread method and got an identical result.
improved efficiency in the case of a provided scale factor, fixed for cases where scale factor is not provided
Adding bpvec to importfrom
significantly speed up calculating scale factors
added documentation for groups. added ucell split data matrix since it is an internal function and can't be imported. minor code cleanup.
removed redundant split matrix function (already present). added matrix dependency to imports.
rolled back function renaming
Update performNormalization.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.