-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window hints #436
base: master
Are you sure you want to change the base?
Window hints #436
Conversation
@blackketter @lougreenwood @mmroczka Would you mind giving it a try? There are two changes:
|
That's pretty neat! I like it. A LOT. Some feedback... Window Hints:
Menu Hints:
I have been playing with some code that provides keys for refresh and lock of hints. These should really compliment these new menu hints! |
Agreed, hints are currently shown for windows whose center or top-left are visible. I'm currently using the Accessbility API's "element at position" function to test for visibility which makes it difficult/slow to test for visible areas. Ideally what I need is an algorithm to calculate the visible areas of a list of 2d rectangles with z-indices. I found Painter's algorithm which might be relevant. Although I think checking the top-right and bottom-left and bottom-right corners could solve most of these edge cases.
Could you share examples?
Noted. |
Sounds like a homework assignment for a CS class. :) Seems to me that you can compare two rectangles for occlusion and generate zero to 4 visible rectangles. Then recursively test those visible rectangles against the next rectangle. When you are done you have a list of visible rectangles. Exercise left to the reader.
Looking again, the examples I see are related to menus on the right of the menubar, which you said didn't work. |
I do see one other issue with windows. If the current frontmost application does not have any windows open, the topmost window from the other applications is not hinted. |
This addition is fire! 🔥 I think the only feedback I'd have is that we shouldn't change to numbers for window hints. Reaching to the number row sucks. This mode even works well even on multiple monitors. It seems to only occasionally not recognize that there are windows on the other monitors. Generally, the same overlap problem that @blackketter mentioned. It'd be a really cool feature to make the window hints for an application always be the same and never changing. For instance, you could make a window be the first 3 letters of the application. |
Hey, first of all, awesome app, it's really useful! As soon as I started using it I thought that it would be super useful to be able to do window switching with it, so I found this branch and tried it out, but found that it is somehow super slow. When I open the hints the yellow clicking hints immediately show up, but I can't activate any of them. After about 10 seconds the window hints show up, after which I can now use any of the hints for the windows or for clicking. Just wanted to let you know about this issue! |
No description provided.