Merge pull request #148 from ctindogaru/impose-min-deposit

Enforce minimum deposit on create method from the factory

sputnikdao-factory2/Cargo.toml

@@ -10,3 +10,6 @@ crate-type = ["cdylib", "rlib"]
 
 [dependencies]
 near-sdk = { version = "4.0.0-pre.4", features = ["unstable"]  }
+
+[dev-dependencies]
+near-sdk-sim = "4.0.0-pre.4"

sputnikdao-factory2/src/factory_manager.rs

@@ -98,7 +98,15 @@ impl FactoryManager {
         assert!(env::storage_has_key(&code_hash), "Contract doesn't exist");
         // Load input (wasm code).
         let code = env::storage_read(&code_hash).expect("ERR_NO_HASH");
-        // Schedule a Promise tx to account_id
+        // Compute storage cost.
+        let code_len = code.len();
+        let storage_cost = ((code_len + 32) as Balance) * env::storage_byte_cost();
+        assert!(
+            attached_deposit >= storage_cost,
+            "ERR_NOT_ENOUGH_DEPOSIT:{}",
+            storage_cost
+        );
+        // Schedule a Promise tx to account_id.
         let promise_id = env::promise_batch_create(&account_id);
         // Create account first.
         env::promise_batch_action_create_account(promise_id);

sputnikdao-factory2/src/lib.rs

@@ -397,8 +397,24 @@ mod tests {
     use near_sdk::test_utils::{accounts, VMContextBuilder};
     use near_sdk::{testing_env, PromiseResult};
 
+    use near_sdk_sim::to_yocto;
+
     use super::*;
 
+    #[test]
+    #[should_panic(expected = "ERR_NOT_ENOUGH_DEPOSIT")]
+    fn test_create_error() {
+        let mut context = VMContextBuilder::new();
+        testing_env!(context
+            .current_account_id(accounts(0))
+            .predecessor_account_id(accounts(0))
+            .build());
+        let mut factory = SputnikDAOFactory::new();
+
+        testing_env!(context.attached_deposit(to_yocto("5")).build());
+        factory.create("test".parse().unwrap(), "{}".as_bytes().to_vec().into());
+    }
+
     #[test]
     fn test_basics() {
         let mut context = VMContextBuilder::new();
@@ -408,7 +424,7 @@ mod tests {
             .build());
         let mut factory = SputnikDAOFactory::new();
 
-        testing_env!(context.attached_deposit(10).build());
+        testing_env!(context.attached_deposit(to_yocto("6")).build());
         factory.create("test".parse().unwrap(), "{}".as_bytes().to_vec().into());
 
         testing_env!(
@@ -420,7 +436,7 @@ mod tests {
         );
         factory.on_create(
             format!("test.{}", accounts(0)).parse().unwrap(),
-            U128(10),
+            U128(to_yocto("6")),
             accounts(0),
         );
         assert_eq!(