TESTCOV: Sputnik Factory: Ownership #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sleep-No-More
added
P-High
4 tasks
|
We are not compleatly sure that solution for [owner_can_be_a_dao_account] is correct. |
TrevorJTClarke
suggested changes
Mar 29, 2022
|
Changed as required @TrevorJTClarke thanks a lot for the clarification. |
TrevorJTClarke
suggested changes
Apr 1, 2022
sputnikdao-factory2/src/lib.rs
Outdated
Comment on lines
477
to
482
|
|
||
| factory.create(bob(), "{}".as_bytes().to_vec().into()); | ||
|
|
||
| factory.set_owner(alice()); | ||
|
|
||
| assert_eq!(factory.get_owner(), alice()) |
There was a problem hiding this comment.
This logic is wrong - it needs to use the DAO account in the set_owner method, then check that the DAO account is owner in get_owner.
Since you're using bob as the name, it will be something like bob.sputnik-dao.near as the DAO account.
So make sure to change set_owner to be the actual full dao name
There was a problem hiding this comment.
Made the changes, logic should be correct now.
There was a problem hiding this comment.
yes, all fixed - thanks!
…m/nninkovicSQA/sputnik-dao-contract into TESTCOV-Sputnik-Factory-Ownership
TrevorJTClarke
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for Sputnik Factory Ownership test coverage #121
Tests will be written in Rust in a test module inside a respected file (lib.rs).
Recommendations are very welcome.