Skip to content

Commit

Permalink
feat(resharding): setup a conservative default for resharding throttl…
Browse files Browse the repository at this point in the history
…ing (#10143)

Setup the throttle config to batch size = 500KB and batch delay = 100ms.

I tested the performance on a more ambitious configuration with batch
size = 1MB and batch delay = 50ms. The nodes performed well and the
resharding took ~30min. The default I'm proposing shouldn't make the
resharding slower by more than 4x compared to that benchmark so the
total resharding time shouldn't exceed 2 hours.
  • Loading branch information
wacban authored Nov 9, 2023
1 parent 3324d96 commit 0657975
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion core/chain-configs/src/client_config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,9 @@ pub struct StateSplitConfig {

impl Default for StateSplitConfig {
fn default() -> Self {
Self { batch_size: bytesize::ByteSize::mb(30), batch_delay: Duration::from_millis(100) }
// Conservative default for a slower resharding that puts as little
// extra load on the node as possible.
Self { batch_size: bytesize::ByteSize::kb(500), batch_delay: Duration::from_millis(100) }
}
}

Expand Down

0 comments on commit 0657975

Please sign in to comment.