Add metrics comparing the V1 and V2 routing protocols #10060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikurt
approved these changes
Nov 1, 2023
|
|
||
| match (v1_dist, v2_dist) { | ||
| (None, None) => { | ||
| metrics::NETWORK_ROUTED_MSG_DISTANCES.with_label_values(&["v1, v2 NONE"]).inc(); |
There was a problem hiding this comment.
How about the following?
NONE
v1 ONLY
v2 ONLY
I find it confusing to mention v1 or v2 when they are not present.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
| @@ -144,13 +144,41 @@ impl NetworkState { | |||
| .unwrap_or(Ok(())) | |||
| } | |||
|
|
|||
| fn record_routing_protocol_metrics(&self, target: &PeerId) { | |||
There was a problem hiding this comment.
is there a value of knowing what the actual delta is?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally, we expect both routing protocols to achieve the exact same distances. Collecting these metrics will help us further validate the performance of the V2 protocol as we prepare to deprecate V1.