enable debug assertions in CI #10205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ekleog-NEAR
added
C-housekeeping
Ekleog-NEAR
force-pushed
the
debug-assertions-in-ci
branch
from
b982776 to
ed356c3
Compare
nagisa
reviewed
Nov 17, 2023
nagisa
approved these changes
Nov 17, 2023
posvyatokum
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Checked that test that I want to fail fails with these changes.
As per this comment I understand, that we can disable that debug_assert! as it is:
- firing in test that it specifically supposed to fire in
- is part of feature that is going to be disabled with 1.38.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.