Bump various dependency versions #10214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
❤️ |
wacban
approved these changes
Nov 20, 2023
| paint("HEADER", Purple.bold(), use_colour), | ||
| paint("HEADER", Magenta.style().bold(), use_colour), |
There was a problem hiding this comment.
lol, did they actually rename the color when bumping version or do you just like megenta more? :)
There was a problem hiding this comment.
ah nevemind, it's different library
| @@ -538,9 +538,9 @@ impl InfoHelper { | |||
|
|
|||
| fn log_chain_processing_info(&mut self, client: &crate::Client, epoch_id: &EpochId) { | |||
| let chain = &client.chain; | |||
| let use_colour = matches!(self.log_summary_style, LogSummaryStyle::Colored); | |||
| let use_color = matches!(self.log_summary_style, LogSummaryStyle::Colored); | |||
There was a problem hiding this comment.
As a British resident I strongly disagree ;)
There was a problem hiding this comment.
(I'm fine with it, just don't tell the king)
There was a problem hiding this comment.
Heh 😅 turns out ansi_term was written by british people, and yansi by americans, or so it seems :p
Comment on lines
+96
to
+97
| use std::io::IsTerminal; | ||
| std::io::stderr().is_terminal() |
nagisa
added a commit
to Ekleog-NEAR/nearcore
that referenced
this pull request
Nov 23, 2023
This reverts commit 7934b34.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular:
Also:
All this together, alongside with #10201, gets us to zero cargo-audit warnings :)
This might be best reviewed commit-by-commit, to more easily see which changes are due to which dependency (though I tried bumping chrono and replacing ansi_term at the same time, resulting in alternating commits as my test compilations made progress)