Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: simplify split usage [trivial] #10285

Merged
merged 1 commit into from
Dec 4, 2023
Merged

crypto: simplify split usage [trivial] #10285

merged 1 commit into from
Dec 4, 2023

Conversation

mina86
Copy link
Contributor

@mina86 mina86 commented Dec 3, 2023

No description provided.

@mina86 mina86 requested a review from a team as a code owner December 3, 2023 14:58
@mina86 mina86 requested a review from wacban December 3, 2023 14:58
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (21851d2) 71.77% compared to head (b7b1fd2) 71.80%.

Files Patch % Lines
core/crypto/src/signature.rs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10285      +/-   ##
==========================================
+ Coverage   71.77%   71.80%   +0.03%     
==========================================
  Files         712      712              
  Lines      142859   142858       -1     
  Branches   142859   142858       -1     
==========================================
+ Hits       102540   102585      +45     
+ Misses      35611    35569      -42     
+ Partials     4708     4704       -4     
Flag Coverage Δ
backward-compatibility 0.08% <0.00%> (ø)
db-migration 0.08% <0.00%> (ø)
genesis-check 1.25% <50.00%> (-0.01%) ⬇️
integration-tests 36.13% <50.00%> (-0.06%) ⬇️
linux 71.66% <50.00%> (+0.04%) ⬆️
linux-nightly 71.39% <50.00%> (+0.02%) ⬆️
macos 53.89% <50.00%> (-1.12%) ⬇️
pytests 1.48% <50.00%> (-0.01%) ⬇️
sanity-checks 1.28% <0.00%> (+<0.01%) ⬆️
unittests 68.16% <50.00%> (+0.03%) ⬆️
upgradability 0.13% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wacban wacban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akhi3030 akhi3030 added this pull request to the merge queue Dec 4, 2023
Merged via the queue into near:master with commit 1ef2364 Dec 4, 2023
15 of 16 checks passed
wacban pushed a commit that referenced this pull request Dec 4, 2023
wacban pushed a commit that referenced this pull request Dec 4, 2023
@mina86 mina86 deleted the d branch September 6, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants