-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: define range of near-api-js
versions as peerDependency instead of an exact one
#1272
Conversation
v8.9.12 Release (dev → main)
v8.9.14 Release (dev → main)
v8.9.15 Release (dev → main)
… of an exact one
Hey @denbite, create the PR against the dev branch, please. |
@gtsonevv I changed the target branch |
@gtsonevv I merged this into |
Actually, these will be tested next week. We will release after a test of the dev branch (next week). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey, we need to review 1 more PR and then we can make a release |
This PR addresses the problem that occurs when installing dependencies over
npm
, particularly in the case of using another version ofnear-api-js
, whichnpm
believes isn't compatible according to a version specified inpeerDependencies
Example
The package above is going to fail while installing dependencies with the following error
Additional Info
The problem doesn't seem to occur while using
yarn
, orpnpm
, at least the error message doesn't appear.npm
version is10.8.2